Fix lint_single_char_pattern on raw string literal #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
approved these changes
Aug 9, 2019
phansch
added
the
S-waiting-on-author
tesuji
commented
Aug 9, 2019
| --> $DIR/single_char_pattern.rs:61:13 | ||
| | | ||
| LL | x.split(r###"'"###); | ||
| | ^^^^^^^^^^ help: try using a char instead: `'/''` |
There was a problem hiding this comment.
I wonder why the suggestion is not `'\''`. It seems really awkward.
There was a problem hiding this comment.
I think that might be caused by some compiletest-rs normalization of the output. The same happens with other suggestions
|
@bors r+ thanks! |
|
📌 Commit b825cdd has been approved by |
bors
added a commit
that referenced
this pull request
Aug 9, 2019
…=phansch Fix lint_single_char_pattern on raw string literal Closes #4356 changelog: Handle raw string literal on `single_char_literal` lint.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4356
changelog: Handle raw string literal on
single_char_literallint.