Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the cognitive_complexity lint's warning. #4469

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

iddm
Copy link
Contributor

@iddm iddm commented Aug 29, 2019

Adds the value of complexity limit set for the lint
to the warning.

Fixes #4466

Signed-off-by: Victor Polevoy fx@thefx.co

changelog: improve the cognitive_complexity lint's warning message.

@iddm
Copy link
Contributor Author

iddm commented Aug 29, 2019

Sorry, forgot to correct the tests, doing.

Adds the value of complexity limit set for the lint
to the warning.

Fixes rust-lang#4466

Signed-off-by: Victor Polevoy <fx@thefx.co>
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 29, 2019

📌 Commit 87ef86e has been approved by flip1995

bors added a commit that referenced this pull request Aug 29, 2019
Improve the cognitive_complexity lint's warning.

Adds the value of complexity limit set for the lint
to the warning.

Fixes #4466

Signed-off-by: Victor Polevoy <fx@thefx.co>

changelog: improve the `cognitive_complexity` lint's warning message.
@bors
Copy link
Collaborator

bors commented Aug 29, 2019

⌛ Testing commit 87ef86e with merge 83f2eb7...

@bors
Copy link
Collaborator

bors commented Aug 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 83f2eb7 to master...

@bors bors merged commit 87ef86e into rust-lang:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve cognitive_complexity lint by showing the limit in the warning
3 participants