Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant_pattern false positive #4489

Merged

Conversation

JohnTitor
Copy link
Member

Fix #4428

changelog: Fix redundant_pattern false positive

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2019
@JohnTitor JohnTitor force-pushed the fix-redundant-pattern-false-positive branch from 3ddf960 to 8be37fd Compare September 4, 2019 15:50
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to run rustfix on all of the auto applicable lints

tests/ui/patterns.rs Show resolved Hide resolved
@flip1995
Copy link
Member

flip1995 commented Sep 5, 2019

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 5, 2019

📌 Commit 0b3f452 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Sep 5, 2019

⌛ Testing commit 0b3f452 with merge 313b41f...

bors added a commit that referenced this pull request Sep 5, 2019
… r=flip1995

Fix `redundant_pattern` false positive

Fix #4428

changelog: Fix `redundant_pattern` false positive
@bors
Copy link
Collaborator

bors commented Sep 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 313b41f to master...

@bors bors merged commit 0b3f452 into rust-lang:master Sep 5, 2019
@JohnTitor JohnTitor deleted the fix-redundant-pattern-false-positive branch September 5, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False-positive in redundant_pattern lint.
3 participants