Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rustfmt running on AppVeyor for now #4617

Closed
wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 3, 2019

rustfmt doesn't seem to execute correctly right now, causing some
backlog of PRs. It's not critical that it runs on Windows, so I've
disabled it for now.

changelog: none

rustfmt doesn't seem to execute correctly right now, causing some
backlog of PRs. It's not critical that it runs on Windows, so I've
disabled it for now.
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 3, 2019

📌 Commit 0703ec8 has been approved by Manishearth

bors added a commit that referenced this pull request Oct 3, 2019
Disable rustfmt running on AppVeyor for now

rustfmt doesn't seem to execute correctly right now, causing some
backlog of PRs. It's not critical that it runs on Windows, so I've
disabled it for now.
@bors
Copy link
Collaborator

bors commented Oct 3, 2019

⌛ Testing commit 0703ec8 with merge 9f758b7...

@bors
Copy link
Collaborator

bors commented Oct 3, 2019

💔 Test failed - checks-travis

@ghost
Copy link

ghost commented Oct 3, 2019

The reason CI is failing is because rustup-toolchain-install-master now includes cargo by default. We're altering the path to link directly to the toolchain here so it's using that instead of the rustup proxy.

@llogiq
Copy link
Contributor

llogiq commented Oct 3, 2019

@bors r=@Manishearth retry

@bors
Copy link
Collaborator

bors commented Oct 3, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Oct 3, 2019

📌 Commit 0703ec8 has been approved by Manishearth

bors added a commit that referenced this pull request Oct 3, 2019
Disable rustfmt running on AppVeyor for now

rustfmt doesn't seem to execute correctly right now, causing some
backlog of PRs. It's not critical that it runs on Windows, so I've
disabled it for now.

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 3, 2019

⌛ Testing commit 0703ec8 with merge e514587...

@llogiq
Copy link
Contributor

llogiq commented Oct 3, 2019

@bors retry

@mati865
Copy link
Contributor

mati865 commented Oct 3, 2019

@mikerite Cargo path LGTM:

which cargo
/c/Users/appveyor/.cargo/bin/cargo

https://ci.appveyor.com/project/mati865/rust-clippy-k06j7

bors added a commit that referenced this pull request Oct 3, 2019
Disable rustfmt running on AppVeyor for now

rustfmt doesn't seem to execute correctly right now, causing some
backlog of PRs. It's not critical that it runs on Windows, so I've
disabled it for now.

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 3, 2019

⌛ Testing commit 0703ec8 with merge 5845b90...

@llogiq
Copy link
Contributor

llogiq commented Oct 3, 2019

This was missing the 'changelog' line.

@tesuji
Copy link
Contributor

tesuji commented Oct 3, 2019

Do we ever need to run rustfmt on Windows? IIRC rustfmt works consistent on all platforms.
So running rustfmt on Linux CI is enough.

@llogiq
Copy link
Contributor

llogiq commented Oct 3, 2019

I think even if there were differences, we won't likely care about them. This is clippy's CI, not rustfmt's.

@bors
Copy link
Collaborator

bors commented Oct 3, 2019

💔 Test failed - status-appveyor

@ghost
Copy link

ghost commented Oct 3, 2019

If a Windows user ever wanted to contribute it would be nice if they could run the rustfmt test. There is little chance of that if we can't even get it working on CI.

@llogiq
Copy link
Contributor

llogiq commented Oct 3, 2019

The problem appears to be with rustup, not rustfmt.

@mati865
Copy link
Contributor

mati865 commented Oct 3, 2019

@matthiaskrgr probably found the reason, check discord #4620

@ghost
Copy link

ghost commented Oct 3, 2019

Too tired. Ignore my last few posts.

@mati865
Copy link
Contributor

mati865 commented Oct 3, 2019

FYI it has been reported upstream rust-lang/cargo#7475

@phansch phansch closed this Oct 4, 2019
@phansch phansch deleted the disable_app_veyor_rustfmt branch October 4, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants