Prevent replace_consts lint within match patterns
#4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `replace_consts` lint applies within match patterns but the suggestion is incorrect as function calls are disallowed in them. To fix this we prevent the lint from firing within patterns.
JohnTitor
added
the
S-waiting-on-review
phansch
reviewed
Jan 2, 2020
| std::i8::MIN => -1, | ||
| 1..=std::i8::MAX => 1, | ||
| _ => 0 | ||
| }; |
There was a problem hiding this comment.
Could you add a test with if let as well?
There was a problem hiding this comment.
Good catch! I didn't think about that use case. Done.
|
@bors r+ thanks! |
|
📌 Commit 8b36196 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 2, 2020
…, r=phansch Prevent `replace_consts` lint within match patterns Currently `replace_consts` lint applies within match patterns but the suggestion is incorrect as function calls are disallowed in them. To fix this we prevent the lint from firing within patterns. Fixes #4969 changelog: Fix false positive in `replace_consts` lint
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
replace_constslint applies within match patterns but the suggestion is incorrect as function calls are disallowed in them. To fix this we prevent the lint from firing within patterns.Fixes #4969
changelog: Fix false positive in
replace_constslint