Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestions for if_let_some_result #5032

Merged
merged 7 commits into from
Jan 19, 2020
Merged

Add suggestions for if_let_some_result #5032

merged 7 commits into from
Jan 19, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #4991

This approach may be fragile though...

changelog: Add suggestions for if_let_some_result

flip1995
flip1995 reviewed Jan 10, 2020
View reviewed changes
tests/ui/ok_if_let.rs Outdated Show resolved Hide resolved
clippy_lints/src/ok_if_let.rs Show resolved Hide resolved
@JohnTitor
Copy link
Member Author

JohnTitor commented Jan 10, 2020 •
edited
Loading

Also, renamed files and module to if_let_some_result, I think it's more appropriate name.

@bors
Copy link
Collaborator

bors commented Jan 11, 2020

☔ The latest upstream changes (presumably #5040) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Jan 13, 2020

☔ The latest upstream changes (presumably #5042) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 13, 2020
flip1995
flip1995 reviewed Jan 18, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File/module rename is fin 👍

clippy_lints/src/if_let_some_result.rs Outdated Show resolved Hide resolved
clippy_lints/src/if_let_some_result.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

Thanks, now this should be a rock solid suggestion!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 19, 2020

📌 Commit c9f8d03 has been approved by flip1995

bors added a commit that referenced this pull request Jan 19, 2020
@bors
Auto merge of #5032 - JohnTitor:add-sugg-some-result, r=flip1995
fd0428f 
Add suggestions for `if_let_some_result`

Fixes #4991

This approach may be fragile though...

changelog: Add suggestions for `if_let_some_result`
@bors
Copy link
Collaborator

bors commented Jan 19, 2020

⌛ Testing commit c9f8d03 with merge fd0428f...

@bors
Copy link
Collaborator

bors commented Jan 19, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing fd0428f to master...

@bors bors merged commit c9f8d03 into rust-lang:master Jan 19, 2020
@JohnTitor JohnTitor deleted the add-sugg-some-result branch January 19, 2020 13:27
@dllu dllu mentioned this pull request Aug 18, 2021
Closed
@y21 y21 mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

@krishna-veerareddy krishna-veerareddy krishna-veerareddy left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add suggestion to if_let_some_result lint
4 participants
@JohnTitor @bors @flip1995 @krishna-veerareddy