Macro use #5230

DevinR528 · 2020-02-26T18:31:39Z

changelog: This lint enforces Rust 2018 idiom of importing macro's directly without #[macro_use] fixes #5179 .

tests/ui/macro_use_import.stderr

DevinR528 · 2020-02-27T01:14:03Z

I can just turn the "use {}::<macro name>" now. I did attempt to impl the suggestion portion of this and got as far as collecting all the use imports, and macro "references" but see no way of linking them together without ast::visit::Visitor as done in librustc_resolve they even check for the macro_use but only for unused imports.

Should I mess with the failed test this (as in the error below) should not be there and didn't fail on my machine, its from missing-docs?

error[E0277]: the size for values of type `Self` cannot be known at compilation time
  --> $DIR/missing-doc-impl.rs:51:5
   |
LL | pub trait E {
   | ----------- required by `E`
LL |     type AssociatedType;
LL |     type AssociatedTypeDef = Self;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
   |
   = help: the trait `std::marker::Sized` is not implemented for `Self`
   = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>

JohnTitor

The CI failure is unrelated to this PR, should be fixed by #5231.

clippy_lints/src/macro_use.rs

DevinR528 · 2020-02-27T12:52:10Z

I ran the commands the failing tests told be to run
tests/ui/update-references.sh '/home/devinr/aprog/rust/__forks__/rust-clippy/target/debug/test_build_base' 'regex.rs'
and
tests/ui/update-references.sh '/home/devinr/aprog/rust/__forks__/rust-clippy/target/debug/test_build_base' 'single_component_path_imports.rs'
hopefully that was ok.

JohnTitor · 2020-02-27T12:59:09Z

A quick workaround for 4e18568 is cargo clean. Also you should rebase to make CI green.

DevinR528 · 2020-02-27T13:17:49Z

I cargo cleaned locally then git fetch upstrem and git rebase upstream/master?

DevinR528 · 2020-02-27T13:56:12Z

Yay finally thanks for the help getting that working @JohnTitor !

JohnTitor

Nice! I'm not sure we allow to include merge commit here though, it's up to the team. I left a nit point.

clippy_lints/src/macro_use.rs

DevinR528 · 2020-02-27T19:30:01Z

Should I squash that commit, or the last three really into one update-reference.sh commit

DevinR528 · 2020-02-27T22:25:28Z

Dang sorry I can't seem to get a good test run going they all pass locally this time there were a bunch of ICE errors. The 6 tests that failed did so with

error: internal compiler error: src/librustc_mir/dataflow/generic/engine.rs:315: Switch on discriminant of non-ADT

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:881:9

JohnTitor · 2020-02-27T22:37:06Z

It isn't your fault, I can reproduce them on master. Let me take a look.

clippy_lints/src/macro_use.rs

flip1995 · 2020-03-03T10:46:10Z

clippy_lints/src/macro_use.rs

+            then {
+                let msg = "`macro_use` attribute's are no longer needed in the Rust 2018 edition";
+                    let help = format!(
+                        "remove the attribute and import the macro directly `use {}::<macro name>`",


Instead of this, you should use span_lint_and_sugg with Applicability::HasPlaceholders

clippy_lints/src/macro_use.rs

DevinR528 · 2020-03-03T17:24:59Z

Any idea why this timed out, all the tests seemed to pass?

flip1995

LGTM overall. Please remove the empty macro_use_import.stdout file

flip1995 · 2020-03-03T20:10:19Z

clippy_lints/src/macro_use.rs

+    /// **Why is this bad?** Since the Rust 2018 edition you can import
+    /// macro's directly, this is considered idiomatic.
+    ///
+    /// **Known problems:** None.


Maybe add to the known problems, that the suggestion is not auto-applicable.

flip1995 · 2020-03-03T20:12:28Z

Don't worry about the timeout. GHA failed here I guess. (didn't start a new run for the force push, but canceled the prev run because of a new commit)

flip1995 · 2020-03-03T23:12:11Z

Thanks! Impl looks really clean

@bors r+

bors · 2020-03-03T23:12:13Z

📌 Commit 2840f68 has been approved by flip1995

bors · 2020-03-03T23:25:13Z

⌛ Testing commit 2840f68 with merge 3f8656c...

Macro use --- changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

bors · 2020-03-03T23:35:04Z

💔 Test failed - checks-action_test

flip1995 · 2020-03-04T11:59:38Z

@bors retry

bors · 2020-03-04T11:59:46Z

⌛ Testing commit 2840f68 with merge b791260...

Macro use --- changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

bors · 2020-03-04T12:00:51Z

💔 Test failed - checks-action_dev_test

flip1995 · 2020-03-04T12:28:15Z

cargo dev update_lints

DevinR528 · 2020-03-04T13:04:58Z

Do I need to pull first, when I ran it it made no changes

flip1995 · 2020-03-04T13:08:17Z

Oh yeah, you need to rebase first probably.

DevinR528 · 2020-03-04T13:42:52Z

Thats odd it fails locally but passed in CI?

flip1995 · 2020-03-04T13:47:09Z

You accidentally pushed a binary file in 1601106. Can you remove this please?

flip1995 · 2020-03-04T14:02:40Z

Can you squash some commits please? Then this is good to go.

flip1995 · 2020-03-05T12:29:12Z

@bors r+

Thanks!

bors · 2020-03-05T12:29:13Z

📌 Commit 597e02d has been approved by flip1995

Macro use --- changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

bors · 2020-03-05T12:29:22Z

⌛ Testing commit 597e02d with merge a6a8a95...

bors · 2020-03-05T12:33:55Z

💔 Test failed - checks-action_test

flip1995 · 2020-03-05T12:35:53Z

Don't worry about the failure. This is not a issue with Clippy/this PR.

DevinR528 · 2020-03-05T13:38:06Z

Thanks for all the help/input on this everyone!

flip1995 · 2020-03-05T17:26:51Z

@bors retry

bors · 2020-03-05T17:30:57Z

⌛ Testing commit 597e02d with merge 23d2b21...

bors · 2020-03-05T17:44:23Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 23d2b21 to master...

Rename macro_use_import -> macro_use_imports I missed this during review of #5230. We can just do this, without deprecating the old name, since this lint didn't hit nightly rustc yet. changelog: none

DevinR528 commented Feb 26, 2020

View reviewed changes

tests/ui/macro_use_import.stderr Outdated Show resolved Hide resolved

JohnTitor suggested changes Feb 27, 2020

View reviewed changes

clippy_lints/src/macro_use.rs Outdated Show resolved Hide resolved

JohnTitor reviewed Feb 27, 2020

View reviewed changes

clippy_lints/src/macro_use.rs Outdated Show resolved Hide resolved

DevinR528 force-pushed the macro-use branch 2 times, most recently from 4bde11f to be6c313 Compare March 2, 2020 21:14

JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 2, 2020

flip1995 reviewed Mar 3, 2020

View reviewed changes

flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 3, 2020

DevinR528 force-pushed the macro-use branch from be6c313 to 42637ac Compare March 3, 2020 13:57

flip1995 reviewed Mar 3, 2020

View reviewed changes

bors added a commit that referenced this pull request Mar 3, 2020

Auto merge of #5230 - DevinR528:macro-use, r=flip1995

3f8656c

Macro use --- changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 3, 2020

bors added a commit that referenced this pull request Mar 4, 2020

Auto merge of #5230 - DevinR528:macro-use, r=flip1995

b791260

Macro use --- changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

DevinR528 force-pushed the macro-use branch from 2840f68 to 77c483f Compare March 4, 2020 13:26

warn on macro_use attr

597e02d

DevinR528 force-pushed the macro-use branch from 4beab09 to 597e02d Compare March 4, 2020 14:37

bors added a commit that referenced this pull request Mar 5, 2020

Auto merge of #5230 - DevinR528:macro-use, r=flip1995

a6a8a95

Macro use --- changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .

bors merged commit 23d2b21 into rust-lang:master Mar 5, 2020

This was referenced Mar 5, 2020

Add lint for explicit deref and deref_mut method calls #5226

Merged

Add lint on large non scalar const #5248

Merged

add lint on File::read_to_string and File::read_to_end #5272

Merged

This was referenced Mar 5, 2020

Enhance macro_use_imports lint with a auto applicable suggstion #5275

Closed

Rename macro_use_import -> macro_use_imports #5276

Merged

Macro use #5230

Macro use #5230

Conversation

DevinR528 commented Feb 26, 2020

DevinR528 commented Feb 27, 2020 • edited

JohnTitor left a comment

Choose a reason for hiding this comment

DevinR528 commented Feb 27, 2020 • edited

JohnTitor commented Feb 27, 2020

DevinR528 commented Feb 27, 2020

DevinR528 commented Feb 27, 2020

JohnTitor left a comment

Choose a reason for hiding this comment

DevinR528 commented Feb 27, 2020

DevinR528 commented Feb 27, 2020

JohnTitor commented Feb 27, 2020

flip1995 Mar 3, 2020

Choose a reason for hiding this comment

DevinR528 commented Mar 3, 2020

flip1995 left a comment

Choose a reason for hiding this comment

flip1995 Mar 3, 2020

Choose a reason for hiding this comment

flip1995 commented Mar 3, 2020

flip1995 commented Mar 3, 2020

bors commented Mar 3, 2020

bors commented Mar 3, 2020

bors commented Mar 3, 2020

flip1995 commented Mar 4, 2020

bors commented Mar 4, 2020

bors commented Mar 4, 2020

flip1995 commented Mar 4, 2020

DevinR528 commented Mar 4, 2020

flip1995 commented Mar 4, 2020

DevinR528 commented Mar 4, 2020

flip1995 commented Mar 4, 2020

flip1995 commented Mar 4, 2020

flip1995 commented Mar 5, 2020

bors commented Mar 5, 2020

bors commented Mar 5, 2020

bors commented Mar 5, 2020

flip1995 commented Mar 5, 2020

DevinR528 commented Mar 5, 2020

flip1995 commented Mar 5, 2020

bors commented Mar 5, 2020

bors commented Mar 5, 2020

DevinR528 commented Feb 27, 2020 •

edited

DevinR528 commented Feb 27, 2020 •

edited