Avoid running cargo+internal lints when not enabled #5505
Conversation
| @@ -59,8 +59,12 @@ fn is_empty_vec(value: &[String]) -> bool { | |||
|
|
|||
| declare_lint_pass!(CargoCommonMetadata => [CARGO_COMMON_METADATA]); | |||
|
|
|||
| impl EarlyLintPass for CargoCommonMetadata { | |||
| fn check_crate(&mut self, cx: &EarlyContext<'_>, _: &Crate) { | |||
| impl LateLintPass<'_, '_> for CargoCommonMetadata { | |||
There was a problem hiding this comment.
Downside: The cargo lints are now LateLintPasses
|
What's the motivation of this change? |
|
@lzutao when running https://discordapp.com/channels/442252698964721669/459149871191031810/702159543538417714 When I tested a version of this branch, it managed to speed up my testcase (running clippy-driver on testcases inside the rustc repo) by ~10x :) |
|
Thanks a lot @flip1995 ! |
|
To add to this: I ran flamegraph on @bors r=matthiaskrgr |
|
📌 Commit f31502f has been approved by |
Avoid running cargo+internal lints when not enabled r? @matthiaskrgr changelog: none
|
💥 Test timed out |
|
@bors retry |
Avoid running cargo+internal lints when not enabled r? @matthiaskrgr changelog: none
|
💔 Test failed - checks-action_test |
|
@bors retry (please?) |
Avoid running cargo+internal lints when not enabled r? @matthiaskrgr changelog: none
|
💔 Test failed - checks-action_test |
flip1995
added
the
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
…hiaskrgr Avoid running cargo+internal lints when not enabled r? @matthiaskrgr changelog: none
Rollup of 5 pull requests Successful merges: - #5408 (Downgrade match_bool to pedantic) - #5505 (Avoid running cargo+internal lints when not enabled) - #5516 (Add a note to the beta sections of release.md) - #5517 (Deploy time travel) - #5523 (Add lifetime test case for `new_ret_no_self`) Failed merges: r? @ghost changelog: rollup
r? @matthiaskrgr
changelog: none