Change Rc<Box<T>> recommendation to be Rc<T> instead of Box<T> #5899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @yaahc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
yaahc
approved these changes
Aug 12, 2020
clippy_lints/src/types.rs
Outdated
Comment on lines
360
to
366
| _ => panic!("Box that isn't a type"), | ||
| }, | ||
| _ => panic!("Rc without type argument"), | ||
| }; | ||
| let inner_span = match &last_path_segment(&box_ty).args.unwrap().args[0] { | ||
| GenericArg::Type(ty) => ty.span, | ||
| _ => panic!("Box without type argument"), |
There was a problem hiding this comment.
it's probably fine, I don't think any of these branches can get hit, but I think it might be better to early return rather than panicking.
yaahc
approved these changes
Aug 12, 2020
|
@bors r+ |
|
📌 Commit 4e28d99 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 12, 2020
Change Rc<Box<T>> recommendation to be Rc<T> instead of Box<T> Changelog: Fixes #5722
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5722
changelog: Suggest
Rc<Box<T>>->Rc<T>in [redundant_allocation] lint