Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenDNS to doc-valid-idents #6783

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Add OpenDNS to doc-valid-idents #6783

merged 2 commits into from
Feb 25, 2021

Conversation

avitex
Copy link
Contributor

@avitex avitex commented Feb 24, 2021

changelog: This commit adds "OpenDNS" to doc-valid-idents to avoid doc_markdown false positives.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 24, 2021
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Collaborator

bors commented Feb 24, 2021

📌 Commit 51fae4e has been approved by Manishearth

bors added a commit that referenced this pull request Feb 24, 2021
Add OpenDNS to `doc-valid-idents`

This commit adds `"OpenDNS"` to doc-valid-idents to avoid `doc_markdown` false positives.
@bors
Copy link
Collaborator

bors commented Feb 24, 2021

⌛ Testing commit 51fae4e with merge a5b2a56...

@bors
Copy link
Collaborator

bors commented Feb 24, 2021

💔 Test failed - checks-action_test

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? You can take a look at #5996 as an example.

@bors
Copy link
Collaborator

bors commented Feb 24, 2021

☔ The latest upstream changes (presumably #6756) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Thanks!

@Manishearth
Copy link
Member

@bors r=giraffate

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

📌 Commit b0d18e9 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

⌛ Testing commit b0d18e9 with merge 76a689d...

@bors
Copy link
Collaborator

bors commented Feb 25, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 76a689d to master...

@bors bors merged commit 76a689d into rust-lang:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants