Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #3414 test #7678

Merged
merged 1 commit into from Sep 17, 2021
Merged

add #3414 test #7678

merged 1 commit into from Sep 17, 2021

Conversation

lengyijun
Copy link
Contributor

@lengyijun lengyijun commented Sep 16, 2021

changelog: none
fixes #3414

I found #3414 was fixed some time. So I add the tests.

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 16, 2021
@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Collaborator

bors commented Sep 17, 2021

📌 Commit fb78365 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Sep 17, 2021

⌛ Testing commit fb78365 with merge dafe975...

bors added a commit that referenced this pull request Sep 17, 2021
add #3414 test

changelog: none
fixes #3414

I found #3414 was fixed some time. So I add the tests.
@bors
Copy link
Collaborator

bors commented Sep 17, 2021

💔 Test failed - checks-action_test

@giraffate
Copy link
Contributor

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 17, 2021

⌛ Testing commit fb78365 with merge f99b4ad...

@bors
Copy link
Collaborator

bors commented Sep 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing f99b4ad to master...

@bors bors merged commit f99b4ad into rust-lang:master Sep 17, 2021
@lengyijun lengyijun deleted the issue3414 branch October 27, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong_self_convention does not recognize this: Self
5 participants