wrong_self_convention does not recognize this: Self

[yvt]

The following code triggers wrong_self_convention:

struct CellLikeThing<T>(T);

impl<T> CellLikeThing<T> {
    fn into_inner(this: Self) -> T {     // <------ here
        this.0
    }
}

impl<T> std::ops::Deref for CellLikeThing<T> {
    type Target = T;

    fn deref(&self) -> &T {
        &self.0
    }
}

warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
 --> src/main.rs:4:19
  |
4 |     fn into_inner(this: Self) -> T {
  |                   ^^^^
  |
  = note: #[warn(clippy::wrong_self_convention)] on by default
  = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#wrong_self_convention

(Playground)

Receiving Self via a this: Self parameter to avoid method name collisions is an idiomatic pattern for implementing methods on a smart pointer-like type, as exemplified by std::rc::Rc::into_raw.