Cover Result for question_mark
#7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dswij
commented
Oct 19, 2021
dswij
force-pushed
the
question-mark-result
branch
from
2bb659f
to
3fc99b6
Compare
|
Looking good so far, just a small nit. |
|
Thank you! @bors r+ |
|
📌 Commit 083a454 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Hi I think this cause a few false positives in one of my projects (https://github.com/matthiaskrgr/cargo-cache) |
|
Whoops! 😓 #7859 should have been covered by rust-clippy/tests/ui/question_mark.rs Lines 144 to 149 in df65291 I'll be taking a look asap |
bors
added a commit
that referenced
this pull request
Oct 26, 2021
Fix `question_mark` FP on custom error type Closes #7859 #7840 aims to ignore `question_mark` when the return type is custom, which is [covered here](https://github.com/rust-lang/rust-clippy/blob/df65291edd6b89a241fed483ab165c32df468746/tests/ui/question_mark.rs#L144-L149). But this fails when there is a call in conditional predicate changelog: [`question_mark`] Fix false positive when there is call in conditional predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7135
changelog: [
question_mark] now coversResult