fix iter_not_returning_iterator
#8228
Conversation
…n the implementation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
iter_not_returning_iterator_8225
branch
from
66d77a3
to
d98339d
Compare
| error: this method is named `iter` but its return type does not implement `Iterator` | ||
| --> $DIR/iter_not_returning_iterator.rs:50:5 | ||
| | | ||
| LL | fn iter(&self) -> Self::I; |
There was a problem hiding this comment.
From the issue it looks like false positive, is this fixed? I tried the case described in the issue, but it seems that I am still warned.
There was a problem hiding this comment.
The error occurs in a different spot. Before it errored on the trait impl, now it errors on the trait def. The trait def in the issue does not restrict the type in the trait so this is correct. The following test checks if the projection is correctly resolved to a type implementing Iterator.
Either fix would have fixed the fp in the issue.
|
@bors r+ Thanks! |
|
📌 Commit d98339d has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #8225
changelog: Handle type projections in
iter_not_returning_iteratorchangelog: Don't lint
iter_not_returning_iteratorin trait implementationschangelog: Lint
iter_not_returning_iteratorin trait definitions