Handle relative paths in module_files lints #8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
DevinR528
reviewed
Mar 31, 2022
| } else { | ||
| return; | ||
| }; | ||
| let RealFileName::LocalPath(trim_to_src) = &cx.sess().opts.working_dir else { return }; |
There was a problem hiding this comment.
Gotta love the new let-else stuff!
DevinR528
reviewed
Mar 31, 2022
|
@DevinR528 as you wrote the original lint, you are a contributor. 😃 @Alexendoo this is a solid improvement, and the code is also looking good. Thank you for this! @bors r+ |
|
📌 Commit 10a6d87 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem being that when clippy is run in the project's directory
lpwould be a relative path, this wasn't caught by the tests as therelpis an absolute path. Being a relative path it did not start withtrim_src_pathand so was ignoredAlso allowed the removal of some
.to_os_string/.to_ownedschangelog: Fixes [
self_named_module_files] and [mod_module_files] not lintingFixes #8123, cc @DevinR528