Fix extra_unused_lifetimes false positive
#9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dswij
approved these changes
Jun 24, 2022
|
@bors r+ |
|
📌 Commit 87eded6 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
dswij
added a commit
to dswij/rust-clippy
that referenced
this pull request
Jun 24, 2022
This commit adds test for a `extra_unused_lifetimes` false positive from derive (rust-lang#9014). The fix for the FP is introduced in rust-lang#9037.
dswij
added a commit
to dswij/rust-clippy
that referenced
this pull request
Jun 24, 2022
This commit adds test for a `extra_unused_lifetimes` false positive from derive (rust-lang#9014). The fix for the FP is introduced in rust-lang#9037.
|
I've added the test to cover for this in #9043 |
|
Nice! |
bors
added a commit
that referenced
this pull request
Jun 29, 2022
`extra_unused_lifetimes` add FP test case emitting from derived attributes. Add test to cover for #9014 which is fixed in #9037. changelog: [`extra_unused_lifetimes`] Add FP test case emitting from derived attributes. --- Seeing the FP from the test: ```sh $ git revert -m 1 1d1ae10 $ TESTNAME=extra_unused_lifetime cargo uitest ```
|
Sorry to post here, but is there any chance of this fix to also end up in/gets backported to 1.63? |
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9014.
I confirmed the FP on the
crates.iosource as @JohnTitor mentioned, and confirmed that the FP is no longer present following this change.I did not include a test in this PR because I think constructing one would be complicated, and the fix is pretty simple. But please let me know if this is unacceptable.
changelog: fix
extra_unused_lifetimesFP