Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct #[allow] attributes in let_unit_value #9082

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Jul 1, 2022

Fixes part of #9080

Not sure why it doesn't work when the lint is emitted at the statement, but switching it to the local works fine

changelog: Fix direct #[allow] attributes in [let_unit_value]

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 1, 2022
@xFrednet
Copy link
Member

xFrednet commented Jul 1, 2022

Looks good to me, thank you for the fix.

Sir bors, I declare this PR as r+ed. Please test it and merge it, if it's green 🙃

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

📌 Commit a5b70a4 has been approved by xFrednet

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

⌛ Testing commit a5b70a4 with merge 097f765...

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 097f765 to master...

@bors bors merged commit 097f765 into rust-lang:master Jul 1, 2022
@Alexendoo Alexendoo deleted the let_unit_allow branch July 1, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants