Allow let_unit_value in more cases
#9056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
let_unit_indirect
branch
3 times, most recently
from
aa00e5b
to
d773ce0
Compare
|
Thank you! @bors r+ |
|
📌 Commit d773ce0 has been approved by |
Jarcho
force-pushed
the
let_unit_indirect
branch
from
d773ce0
to
a7d8f24
Compare
|
☔ The latest upstream changes (presumably #8666) made this pull request unmergeable. Please resolve the merge conflicts. |
Jarcho
force-pushed
the
let_unit_indirect
branch
from
a7d8f24
to
68c4fee
Compare
|
☔ The latest upstream changes (presumably #9082) made this pull request unmergeable. Please resolve the merge conflicts. |
* View through locals in `let_unit_value` when determining if inference is required * Don't remove typed let bindings for more functions
|
Ping @llogiq. I don't remember if I changed anything since you last checked this. |
|
In any case, this looks good. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
kpreid
added a commit
to kpreid/wgpu
that referenced
this pull request
Jul 30, 2022
The `let_unit_value` lint is new in Rust 1.62. rust-lang/rust-clippy#9056 might quiet it next release, though, so this may or may not be worth doing.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8998
changelog: Lint
let_unit_valueless aggressively when the type is specified