Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9544 #9559

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Fix #9544 #9559

merged 2 commits into from
Oct 3, 2022

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Sep 30, 2022 •
edited by Alexendoo
Loading

Fix #9544

r? @Alexendoo

changelog: [arithmetic_side_effects]: Fix false negative for CustomType / usize, CustomType * float and similar

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2022
@Alexendoo
Copy link
Member

Nice, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 3, 2022

📌 Commit 99363fe has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 3, 2022

⌛ Testing commit 99363fe with merge 087f4d8...

bors added a commit that referenced this pull request Oct 3, 2022
@bors
Auto merge of #9559 - c410-f3r:arith, r=Alexendoo
087f4d8 
Fix #9544

Fix #9544

r? `@Alexendoo`
@bors
Copy link
Collaborator

bors commented Oct 3, 2022

💔 Test failed - checks-action_test

@Alexendoo
Copy link
Member

Stuck a changelog: in the body,

@bors retry

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Oct 3, 2022

Can you r? again?

@bors
Copy link
Collaborator

bors commented Oct 3, 2022

⌛ Testing commit 99363fe with merge e8c1b54...

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Oct 3, 2022

Thanks

@bors
Copy link
Collaborator

bors commented Oct 3, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing e8c1b54 to master...

@bors bors merged commit e8c1b54 into rust-lang:master Oct 3, 2022
@c410-f3r c410-f3r mentioned this pull request Nov 13, 2022
Merged
bors added a commit that referenced this pull request Dec 9, 2022
@bors
Auto merge of #9840 - c410-f3r:arith-2, r=Alexendoo
39f0719 
[`arithmetic-side-effects`]: Consider user-provided pairs

Depends on #9592.

Because of #9559 (comment), r? `@Alexendoo`

```
changelog: [`arithmetic-side-effects`]: Consider user-provided pairs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arithmetic_side_effects misses T / integral, T * float and similar
4 participants
@c410-f3r @Alexendoo @bors @rust-highfive