Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arithmetic-side-effects]: Consider user-provided pairs #9840

Merged
merged 1 commit into from
Dec 9, 2022
Merged

[arithmetic-side-effects]: Consider user-provided pairs #9840

merged 1 commit into from
Dec 9, 2022

Conversation

c410-f3r
Copy link
Contributor

Depends on #9592.

Because of #9559 (comment), r? @Alexendoo

changelog: [`arithmetic-side-effects`]: Consider user-provided pairs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 13, 2022
@Alexendoo Alexendoo added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 14, 2022
@c410-f3r c410-f3r mentioned this pull request Nov 18, 2022
Closed
@Jarcho Jarcho added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Nov 20, 2022
@c410-f3r
Copy link
Contributor Author

@Alexendoo #9592 has been merged.

Alexendoo
Alexendoo reviewed Dec 1, 2022
View reviewed changes
clippy_lints/src/utils/conf.rs Outdated Show resolved Hide resolved
clippy_lints/src/utils/conf.rs Outdated Show resolved Hide resolved
clippy_lints/src/utils/conf.rs Outdated Show resolved Hide resolved
@Alexendoo
Copy link
Member

We talked about this in the meeting the other day, one thing that came up was that we could use _ instead of * for the wildcard type. There wasn't a conclusion either way though, what do you think about that @c410-f3r?

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Dec 2, 2022

We talked about this in the meeting the other day, one thing that came up was that we could use _ instead of * for the wildcard type. There wasn't a conclusion either way though, what do you think about that @c410-f3r?

* is the canonical glob character used in strings but now that pairs are described as arrays of two elements, it shouldn't matter which one is better as long as the intended behavior is documented. If desired, I can add support for both.

@c410-f3r c410-f3r force-pushed the arith-2 branch 3 times, most recently from 7ac5c39 to 8aa2023 Compare December 4, 2022 12:08
Alexendoo
Alexendoo reviewed Dec 7, 2022
View reviewed changes
clippy_lints/src/utils/conf.rs Outdated Show resolved Hide resolved
clippy_lints/src/utils/conf.rs Outdated Show resolved Hide resolved
Alexendoo
Alexendoo reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple code style things and we can get this merged (once bors becomes unstuck)

clippy_lints/src/operators/arithmetic_side_effects.rs Outdated Show resolved Hide resolved
clippy_lints/src/operators/arithmetic_side_effects.rs Outdated Show resolved Hide resolved
@Alexendoo
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2022

📌 Commit 1f92f97 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 9, 2022

⌛ Testing commit 1f92f97 with merge 39f0719...

@bors
Copy link
Collaborator

bors commented Dec 9, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 39f0719 to master...

@bors bors merged commit 39f0719 into rust-lang:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@c410-f3r @Alexendoo @bors @flip1995 @rust-highfive @Jarcho