Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collapsible_match] specify field name when destructuring structs #9685

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

kraktus
Copy link
Contributor

@kraktus kraktus commented Oct 21, 2022

changelog: [collapsible_match] specify field name when destructuring structs

fix #9647

I wasn't the sure about the best way to convey the message in the lint message since it does not use suggestion. Because I liked the former output highlighting both spans, I've left it as before, only modifying the span label.

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 21, 2022
@llogiq
Copy link
Contributor

llogiq commented Oct 21, 2022

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 21, 2022

📌 Commit 487c6fc has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 21, 2022

⌛ Testing commit 487c6fc with merge b2e5a71...

@bors
Copy link
Collaborator

bors commented Oct 21, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing b2e5a71 to master...

@bors bors merged commit b2e5a71 into rust-lang:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapsible_match suggestion does not compile
4 participants