cargo doc: Support JSON messages. #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.30 has added support for JSON messages with rustdoc. This allows the build command to capture errors and warnings for rustdoc. Previously messages were forced to the build panel (older versions will continue to behave this way).
|
bors r+ |
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Sep 5, 2018
334: cargo doc: Support JSON messages. r=ehuss a=ehuss 1.30 has added support for JSON messages with rustdoc. This allows the build command to capture errors and warnings for rustdoc. Previously messages were only displayed in the build panel (older versions will continue to behave this way). <img width="644" alt="image" src="https://user-images.githubusercontent.com/43198/44379176-9e819e80-a4b9-11e8-9c6b-e4c77815cafc.png"> 335: Syntax: Fix raw pointers, and index `const` and `static` symbols (for Goto-Symbol). r=ehuss a=ehuss This changes the scope of the const/static identifier to `entity.name.constant`. Depending on your color scheme, this will likely change the color from the old `constant.other` scope. I think this better follows the spirit of Sublime's naming conventions. Also includes changes to support raw pointers. `*const` and `*mut` is now scoped as `storage.modifier.rust`. These need to go together because of the keyword `const` interaction. <img width="836" alt="image" src="https://user-images.githubusercontent.com/43198/44434629-1656d400-a561-11e8-8f1f-fc8191fecccf.png"> Co-authored-by: Eric Huss <eric@huss.org>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.30 has added support for JSON messages with rustdoc. This allows the build
command to capture errors and warnings for rustdoc. Previously messages were
only displayed in the build panel (older versions will continue to behave this way).