Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Who should review new PRs? #137

Closed
Xanewok opened this issue Nov 5, 2020 · 10 comments
Closed

Who should review new PRs? #137

Xanewok opened this issue Nov 5, 2020 · 10 comments

Comments

@Xanewok
Copy link
Member

Xanewok commented Nov 5, 2020

In an effort to streamline reviewing, this repository was moved to the rust-lang organization (from legacy the rust-dev-tools one) in order to use the @bors bot (similar to other repos under rust-lang org). While this should be now complete, there remains a question who should be reviewing the PRs 😅

@Manishearth has helped me as an interim reviewer but we discussed on Discord that it'd be good to establish others instead as reviewers.

@ibabushkin @gnzlbg @JohnTitor do you have time and would like to review any new PRs? If not, do you have an idea who could?

Disclaimer: I'm trying to integrate semverver into https://github.com/paritytech/cargo-unleash for automatic workspace package publishing, hence why I'm interested in refreshing semverver a bit 🙂

@JohnTitor
Copy link
Member

I'm happy to help maintain since libc CI also uses this crate and I'm also interested in the updates :)

@Manishearth
Copy link
Member

@Xanewok i'm happy for you and ilya to be reviewing, and y'all can choose additional reviewers if you'd like.

@Xanewok
Copy link
Member Author

Xanewok commented Nov 23, 2020

@JohnTitor you should now have bors review permissions as per rust-lang/team#486 🙂

@JohnTitor
Copy link
Member

@Xanewok Thanks! Feel free to r? or ping me if a review is needed :)

@JohnTitor
Copy link
Member

Semi-related to this: It'd be great if the reviewers also have permission on the repo. I currently cannot edit/close PRs/issues like #177 :(

@Xanewok
Copy link
Member Author

Xanewok commented Mar 29, 2021

@pietroalbini is it possible to do this via rust-lang/team?

@Manishearth
Copy link
Member

@Xanewok has admin rights on the repo and can add others for edit/triage access, fwiw

@Xanewok
Copy link
Member Author

Xanewok commented Mar 29, 2021

Oh right, thanks. @JohnTitor can you see if you have access to triage features?

@JohnTitor
Copy link
Member

@Xanewok Yep, thanks!

@JohnTitor
Copy link
Member

Currently, reviewing is done by me and sometimes @Xanewok, closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants