Skip to content

Commit

Permalink
auto merge of #9979 : alexcrichton/rust/print-no-alloc, r=huonw
Browse files Browse the repository at this point in the history
Instead use format_args! to pass around a struct to pass along into std::fmt
  • Loading branch information
bors committed Oct 21, 2013
2 parents cd59a7c + df6225b commit 04ac697
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 8 deletions.
19 changes: 18 additions & 1 deletion src/libstd/rt/io/stdio.rs
Expand Up @@ -8,6 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use fmt;
use libc;
use option::{Option, Some, None};
use result::{Ok, Err};
Expand Down Expand Up @@ -56,7 +57,9 @@ pub fn stderr() -> StdWriter {
pub fn print(s: &str) {
// XXX: need to see if not caching stdin() is the cause of performance
// issues, it should be possible to cache a stdout handle in each Task
// and then re-use that across calls to print/println
// and then re-use that across calls to print/println. Note that the
// resolution of this comment will affect all of the prints below as
// well.
stdout().write(s.as_bytes());
}

Expand All @@ -68,6 +71,20 @@ pub fn println(s: &str) {
out.write(['\n' as u8]);
}

/// Similar to `print`, but takes a `fmt::Arguments` structure to be compatible
/// with the `format_args!` macro.
pub fn print_args(fmt: &fmt::Arguments) {
let mut out = stdout();
fmt::write(&mut out as &mut Writer, fmt);
}

/// Similar to `println`, but takes a `fmt::Arguments` structure to be
/// compatible with the `format_args!` macro.
pub fn println_args(fmt: &fmt::Arguments) {
let mut out = stdout();
fmt::writeln(&mut out as &mut Writer, fmt);
}

/// Representation of a reader of a standard input stream
pub struct StdReader {
priv inner: ~RtioFileStream
Expand Down
9 changes: 2 additions & 7 deletions src/libsyntax/ext/expand.rs
Expand Up @@ -999,16 +999,11 @@ pub fn std_macros() -> @str {
macro_rules! writeln(($dst:expr, $($arg:tt)*) => (
format_args!(|args| { ::std::fmt::writeln($dst, args) }, $($arg)*)
))
// FIXME(#6846) once stdio is redesigned, this shouldn't perform an
// allocation but should rather delegate to an invocation of
// write! instead of format!
macro_rules! print (
($($arg:tt)*) => (::std::io::print(format!($($arg)*)))
($($arg:tt)*) => (format_args!(::std::rt::io::stdio::print_args, $($arg)*))
)
// FIXME(#6846) once stdio is redesigned, this shouldn't perform an
// allocation but should rather delegate to an io::Writer
macro_rules! println (
($($arg:tt)*) => (::std::io::println(format!($($arg)*)))
($($arg:tt)*) => (format_args!(::std::rt::io::stdio::println_args, $($arg)*))
)

macro_rules! local_data_key (
Expand Down

0 comments on commit 04ac697

Please sign in to comment.