Skip to content

Commit

Permalink
Refactor loop into iterator; simplify negation logic.
Browse files Browse the repository at this point in the history
  • Loading branch information
IsakNyberg committed Apr 13, 2022
1 parent dc4bfcb commit 53b2aca
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions compiler/rustc_error_messages/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,18 +320,12 @@ impl MultiSpan {

/// Returns `true` if any of the primary spans are displayable.
pub fn has_primary_spans(&self) -> bool {
self.primary_spans.iter().any(|sp| !sp.is_dummy())
!self.primary_spans.iter().all(|sp| sp.is_dummy())
}

/// Returns `true` if this contains only a dummy primary span with any hygienic context.
pub fn is_dummy(&self) -> bool {
let mut is_dummy = true;
for span in &self.primary_spans {
if !span.is_dummy() {
is_dummy = false;
}
}
is_dummy
self.primary_spans.iter().all(|sp| sp.is_dummy())
}

/// Replaces all occurrences of one Span with another. Used to move `Span`s in areas that don't
Expand Down

0 comments on commit 53b2aca

Please sign in to comment.