-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #106200 - compiler-errors:suggest-impl-trait, r=estebank
Suggest `impl Fn*` and `impl Future` in `-> _` return suggestions Follow-up to #106172, only the last commit is relevant. Can rebase once that PR is landed for easier review. Suggests `impl Future` and `impl Fn{,Mut,Once}` in `-> _` return suggestions. r? `@estebank`
- Loading branch information
Showing
9 changed files
with
220 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -193,6 +193,7 @@ symbols! { | |
FromIterator, | ||
FromResidual, | ||
Future, | ||
FutureOutput, | ||
FxHashMap, | ||
FxHashSet, | ||
GlobalAlloc, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
fn fn_once() -> _ { | ||
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types [E0121] | ||
//~| NOTE not allowed in type signatures | ||
//~| HELP replace with an appropriate return type | ||
//~| SUGGESTION impl FnOnce() | ||
//~| NOTE for more information on `Fn` traits and closure types | ||
let x = String::new(); | ||
|| { | ||
drop(x); | ||
} | ||
} | ||
|
||
fn fn_mut() -> _ { | ||
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types [E0121] | ||
//~| NOTE not allowed in type signatures | ||
//~| HELP replace with an appropriate return type | ||
//~| SUGGESTION impl FnMut(char) | ||
//~| NOTE for more information on `Fn` traits and closure types | ||
let x = String::new(); | ||
|c| { | ||
x.push(c); | ||
} | ||
} | ||
|
||
fn fun() -> _ { | ||
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types [E0121] | ||
//~| NOTE not allowed in type signatures | ||
//~| HELP replace with an appropriate return type | ||
//~| SUGGESTION impl Fn() -> i32 | ||
//~| NOTE for more information on `Fn` traits and closure types | ||
|| 1i32 | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types | ||
--> $DIR/suggest-return-closure.rs:1:17 | ||
| | ||
LL | fn fn_once() -> _ { | ||
| ^ | ||
| | | ||
| not allowed in type signatures | ||
| help: replace with an appropriate return type: `impl FnOnce()` | ||
| | ||
= note: for more information on `Fn` traits and closure types, see https://doc.rust-lang.org/book/ch13-01-closures.html | ||
|
||
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types | ||
--> $DIR/suggest-return-closure.rs:13:16 | ||
| | ||
LL | fn fn_mut() -> _ { | ||
| ^ | ||
| | | ||
| not allowed in type signatures | ||
| help: replace with an appropriate return type: `impl FnMut(char)` | ||
| | ||
= note: for more information on `Fn` traits and closure types, see https://doc.rust-lang.org/book/ch13-01-closures.html | ||
|
||
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types | ||
--> $DIR/suggest-return-closure.rs:25:13 | ||
| | ||
LL | fn fun() -> _ { | ||
| ^ | ||
| | | ||
| not allowed in type signatures | ||
| help: replace with an appropriate return type: `impl Fn() -> i32` | ||
| | ||
= note: for more information on `Fn` traits and closure types, see https://doc.rust-lang.org/book/ch13-01-closures.html | ||
|
||
error: aborting due to 3 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0121`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// edition: 2021 | ||
|
||
async fn a() -> i32 { | ||
0 | ||
} | ||
|
||
fn foo() -> _ { | ||
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types [E0121] | ||
//~| NOTE not allowed in type signatures | ||
//~| HELP replace with an appropriate return type | ||
//~| SUGGESTION impl Future<Output = i32> | ||
a() | ||
} | ||
|
||
fn bar() -> _ { | ||
//~^ ERROR the placeholder `_` is not allowed within types on item signatures for return types [E0121] | ||
//~| NOTE not allowed in type signatures | ||
//~| HELP replace with an appropriate return type | ||
//~| SUGGESTION impl Future<Output = i32> | ||
async { a().await } | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types | ||
--> $DIR/suggest-return-future.rs:7:13 | ||
| | ||
LL | fn foo() -> _ { | ||
| ^ | ||
| | | ||
| not allowed in type signatures | ||
| help: replace with an appropriate return type: `impl Future<Output = i32>` | ||
|
||
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types | ||
--> $DIR/suggest-return-future.rs:15:13 | ||
| | ||
LL | fn bar() -> _ { | ||
| ^ | ||
| | | ||
| not allowed in type signatures | ||
| help: replace with an appropriate return type: `impl Future<Output = i32>` | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0121`. |