Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #57158 - estebank:as-ref, r=zackmdavis
Suggest `.as_ref()` when appropriate for `Option` and `Result` Fix #55198.
- Loading branch information
Showing
5 changed files
with
172 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:6:27 | ||
| | ||
LL | opt.map(|arg| takes_ref(arg)); | ||
| - ^^^ expected &Foo, found struct `Foo` | ||
| | | ||
| help: consider using `as_ref` instead: `as_ref().` | ||
| | ||
= note: expected type `&Foo` | ||
found type `Foo` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:8:37 | ||
| | ||
LL | opt.and_then(|arg| Some(takes_ref(arg))); | ||
| - ^^^ expected &Foo, found struct `Foo` | ||
| | | ||
| help: consider using `as_ref` instead: `as_ref().` | ||
| | ||
= note: expected type `&Foo` | ||
found type `Foo` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:11:27 | ||
| | ||
LL | opt.map(|arg| takes_ref(arg)); | ||
| - ^^^ expected &Foo, found struct `Foo` | ||
| | | ||
| help: consider using `as_ref` instead: `as_ref().` | ||
| | ||
= note: expected type `&Foo` | ||
found type `Foo` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:13:35 | ||
| | ||
LL | opt.and_then(|arg| Ok(takes_ref(arg))); | ||
| - ^^^ expected &Foo, found struct `Foo` | ||
| | | ||
| help: consider using `as_ref` instead: `as_ref().` | ||
| | ||
= note: expected type `&Foo` | ||
found type `Foo` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:16:27 | ||
| | ||
LL | let y: Option<&usize> = x; | ||
| ^ | ||
| | | ||
| expected enum `std::option::Option`, found reference | ||
| help: you can convert from `&Option<T>` to `Option<&T>` using `.as_ref()`: `x.as_ref()` | ||
| | ||
= note: expected type `std::option::Option<&usize>` | ||
found type `&std::option::Option<usize>` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:19:35 | ||
| | ||
LL | let y: Result<&usize, &usize> = x; | ||
| ^ expected enum `std::result::Result`, found reference | ||
| | ||
= note: expected type `std::result::Result<&usize, &usize>` | ||
found type `&std::result::Result<usize, usize>` | ||
help: you can convert from `&Result<T, E>` to `Result<&T, &E>` using `.as_ref()` | ||
| | ||
LL | let y: Result<&usize, &usize> = x.as_ref(); | ||
| ^^^^^^^^^^ | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/as-ref.rs:23:34 | ||
| | ||
LL | let y: Result<&usize, usize> = x; | ||
| ^ expected enum `std::result::Result`, found reference | ||
| | ||
= note: expected type `std::result::Result<&usize, usize>` | ||
found type `&std::result::Result<usize, usize>` | ||
|
||
error: aborting due to 7 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0308`. |