-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #60415 - jespersm:pr_unused_import_45268, r=petrochenkov
Fix #45268 by saving all NodeId's for resolved traits. This fixes #45268 by saving all NodeId's for resolved traits. I've verifies this against master (but only on MacOS). However, with some recent changes in master, it appears that there are some failures on my machine. They are unrelated to my changes, anyway.
- Loading branch information
Showing
10 changed files
with
127 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// compile-pass | ||
|
||
#![warn(unused_imports)] // Warning explanation here, it's OK | ||
|
||
mod test { | ||
pub trait A { | ||
fn a(); | ||
} | ||
|
||
impl A for () { | ||
fn a() { } | ||
} | ||
|
||
pub trait B { | ||
fn b(self); | ||
} | ||
|
||
impl B for () { | ||
fn b(self) { } | ||
} | ||
|
||
pub trait Unused { | ||
} | ||
} | ||
|
||
use test::Unused; // This is really unused, so warning is OK | ||
use test::A; // This is used by the test2::func() through import of super::* | ||
use test::B; // This is used by the test2::func() through import of super::* | ||
|
||
mod test2 { | ||
use super::*; | ||
pub fn func() { | ||
let _ = <()>::a(); | ||
let _ = ().b(); | ||
test3::inner_func(); | ||
} | ||
mod test3 { | ||
use super::*; | ||
pub fn inner_func() { | ||
let _ = <()>::a(); | ||
let _ = ().b(); | ||
} | ||
} | ||
} | ||
|
||
fn main() { | ||
test2::func(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
warning: unused import: `test::Unused` | ||
--> $DIR/unused_import_warning_issue_45268.rs:26:5 | ||
| | ||
LL | use test::Unused; // This is really unused, so warning is OK | ||
| ^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/unused_import_warning_issue_45268.rs:3:9 | ||
| | ||
LL | #![warn(unused_imports)] // Warning explanation here, it's OK | ||
| ^^^^^^^^^^^^^^ | ||
|