Skip to content

Commit

Permalink
Set exceeding bitshifts lint to deny
Browse files Browse the repository at this point in the history 
Discussed in #18587
  • Loading branch information
@hirschenberger
hirschenberger committed Nov 11, 2014
1 parent d962fb0 commit 7dab903
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc/lint/builtin.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ declare_lint!(UNUSED_COMPARISONS, Warn,
declare_lint!(OVERFLOWING_LITERALS, Warn,
"literal out of range for its type")

declare_lint!(EXCEEDING_BITSHIFTS, Allow,
declare_lint!(EXCEEDING_BITSHIFTS, Deny,
"shift exceeds the type's number of bits")

pub struct TypeLimits {
Expand Down

5 comments on commit 7dab903

@bors
Copy link
Contributor

@bors bors commented on 7dab903 Nov 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from thestinger
at hirschenberger@7dab903

@bors
Copy link
Contributor

@bors bors commented on 7dab903 Nov 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging hirschenberger/rust/master = 7dab903 into auto

@bors
Copy link
Contributor

@bors bors commented on 7dab903 Nov 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hirschenberger/rust/master = 7dab903 merged ok, testing candidate = 5db8381

@bors
Copy link
Contributor

@bors bors commented on 7dab903 Nov 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2239
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2237
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2230
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2237
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2231
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2230
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2230
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2234
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2227
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2226
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2230
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1889
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1886
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1893
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/730
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/723
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/717

@bors
Copy link
Contributor

@bors bors commented on 7dab903 Nov 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 5db8381

Please sign in to comment.