Skip to content

Commit

Permalink
add fixme about the type_op_normalize query in NLL HRTB diagnostics
Browse files Browse the repository at this point in the history
  • Loading branch information
lqd committed Aug 18, 2021
1 parent 311578d commit 8343806
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,14 @@ where
let mut fulfill_cx = <dyn TraitEngine<'_>>::new(tcx);

let mut selcx = SelectionContext::new(infcx);
let (param_env, value) = key.into_parts();

// FIXME(lqd): Unify and de-duplicate the following with the actual
// `rustc_traits::type_op::type_op_normalize` query to allow the span we need in the
// `ObligationCause`. The normalization results are currently different between
// `AtExt::normalize` used in the query and `normalize` called below: the former fails
// to normalize the `nll/relate_tys/impl-fn-ignore-binder-via-bottom.rs` test. Check
// after #85499 lands to see if its fixes have erased this difference.
let (param_env, value) = key.into_parts();
let Normalized { value: _, obligations } = rustc_trait_selection::traits::normalize(
&mut selcx,
param_env,
Expand Down

0 comments on commit 8343806

Please sign in to comment.