Skip to content

Commit

Permalink
Add missing regression tests
Browse files Browse the repository at this point in the history
for a couple of issues
  • Loading branch information
gurry committed Mar 9, 2024
1 parent 4d4bb49 commit b1f4657
Show file tree
Hide file tree
Showing 4 changed files with 109 additions and 0 deletions.
13 changes: 13 additions & 0 deletions tests/ui/trait-bounds/ice-unsized-struct-arg-issue-121612.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Regression test for issue #121612

trait Trait {}
impl Trait for bool {}
struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
//~^ ERROR cannot find type `Idx` in this scope
//~| ERROR cannot find type `Idx` in this scope
type MySliceBool = MySlice<[bool]>;
const MYSLICE_GOOD: &MySliceBool = &MySlice(true, [false]);
//~^ ERROR the size for values of type `[bool]` cannot be known at compilation time
//~| ERROR the size for values of type `[bool]` cannot be known at compilation time

fn main() {}
57 changes: 57 additions & 0 deletions tests/ui/trait-bounds/ice-unsized-struct-arg-issue-121612.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
error[E0412]: cannot find type `Idx` in this scope
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:5:30
|
LL | struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
| ^^^ not found in this scope

error[E0412]: cannot find type `Idx` in this scope
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:5:38
|
LL | struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
| ^^^ not found in this scope

error[E0277]: the size for values of type `[bool]` cannot be known at compilation time
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:9:22
|
LL | const MYSLICE_GOOD: &MySliceBool = &MySlice(true, [false]);
| ^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `Sized` is not implemented for `[bool]`
note: required by an implicit `Sized` bound in `MySlice`
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:5:16
|
LL | struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
| ^ required by the implicit `Sized` requirement on this type parameter in `MySlice`
help: you could relax the implicit `Sized` bound on `T` if it were used through indirection like `&T` or `Box<T>`
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:5:16
|
LL | struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
| ^ - ...if indirection were used here: `Box<T>`
| |
| this could be changed to `T: ?Sized`...

error[E0277]: the size for values of type `[bool]` cannot be known at compilation time
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:9:22
|
LL | const MYSLICE_GOOD: &MySliceBool = &MySlice(true, [false]);
| ^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `Sized` is not implemented for `[bool]`
note: required by an implicit `Sized` bound in `MySlice`
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:5:16
|
LL | struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
| ^ required by the implicit `Sized` requirement on this type parameter in `MySlice`
help: you could relax the implicit `Sized` bound on `T` if it were used through indirection like `&T` or `Box<T>`
--> $DIR/ice-unsized-struct-arg-issue-121612.rs:5:16
|
LL | struct MySlice<T: FnOnce(&T, Idx) -> Idx>(bool, T);
| ^ - ...if indirection were used here: `Box<T>`
| |
| this could be changed to `T: ?Sized`...
= note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`

error: aborting due to 4 previous errors

Some errors have detailed explanations: E0277, E0412.
For more information about an error, try `rustc --explain E0277`.
9 changes: 9 additions & 0 deletions tests/ui/trait-bounds/ice-unsized-struct-arg-issue2-121424.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Regression test for issue #121424
#[repr(C)]
struct MySlice<T: Copy>(bool, T);
type MySliceBool = MySlice<[bool]>;
const MYSLICE_GOOD: &MySliceBool = &MySlice(true, [false]);
//~^ ERROR the trait bound `[bool]: Copy` is not satisfied
//~| ERROR the trait bound `[bool]: Copy` is not satisfied

fn main() {}
30 changes: 30 additions & 0 deletions tests/ui/trait-bounds/ice-unsized-struct-arg-issue2-121424.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
error[E0277]: the trait bound `[bool]: Copy` is not satisfied
--> $DIR/ice-unsized-struct-arg-issue2-121424.rs:5:22
|
LL | const MYSLICE_GOOD: &MySliceBool = &MySlice(true, [false]);
| ^^^^^^^^^^^ the trait `Copy` is not implemented for `[bool]`
|
= help: the trait `Copy` is implemented for `[T; N]`
note: required by a bound in `MySlice`
--> $DIR/ice-unsized-struct-arg-issue2-121424.rs:3:19
|
LL | struct MySlice<T: Copy>(bool, T);
| ^^^^ required by this bound in `MySlice`

error[E0277]: the trait bound `[bool]: Copy` is not satisfied
--> $DIR/ice-unsized-struct-arg-issue2-121424.rs:5:22
|
LL | const MYSLICE_GOOD: &MySliceBool = &MySlice(true, [false]);
| ^^^^^^^^^^^ the trait `Copy` is not implemented for `[bool]`
|
= help: the trait `Copy` is implemented for `[T; N]`
note: required by a bound in `MySlice`
--> $DIR/ice-unsized-struct-arg-issue2-121424.rs:3:19
|
LL | struct MySlice<T: Copy>(bool, T);
| ^^^^ required by this bound in `MySlice`
= note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0277`.

0 comments on commit b1f4657

Please sign in to comment.