Skip to content

Commit

Permalink
librustc: Fix pattern matching on cross crate newtype structs.
Browse files Browse the repository at this point in the history
  • Loading branch information
luqmana committed Apr 30, 2013
1 parent dbcc3fe commit b50aa82
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/librustc/middle/check_match.rs
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,8 @@ pub fn specialize(cx: @MatchCheckCtxt,
Some(vec::append(args, vec::from_slice(r.tail())))
}
def_variant(_, _) => None,

def_fn(*) |
def_struct(*) => {
// FIXME #4731: Is this right? --pcw
let new_args;
Expand Down
1 change: 1 addition & 0 deletions src/librustc/middle/mem_categorization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,7 @@ pub impl mem_categorization_ctxt {
self.cat_pattern(subcmt, *subpat, op);
}
}
Some(&ast::def_fn(*)) |
Some(&ast::def_struct(*)) => {
for subpats.each |subpat| {
let cmt_field = self.cat_anon_struct_field(*subpat,
Expand Down
1 change: 1 addition & 0 deletions src/librustc/middle/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4279,6 +4279,7 @@ pub impl Resolver {
pat_enum(path, _) => {
// This must be an enum variant, struct or const.
match self.resolve_path(path, ValueNS, false, visitor) {
Some(def @ def_fn(*)) |
Some(def @ def_variant(*)) |
Some(def @ def_struct(*)) |
Some(def @ def_const(*)) => {
Expand Down
4 changes: 4 additions & 0 deletions src/librustc/middle/trans/_match.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ pub fn variant_opt(bcx: block, pat_id: ast::node_id)
}
::core::util::unreachable();
}
ast::def_fn(*) |
ast::def_struct(_) => {
return lit(UnitLikeStructLit(pat_id));
}
Expand Down Expand Up @@ -818,6 +819,7 @@ pub fn get_options(bcx: block, m: &[@Match], col: uint) -> ~[Opt] {
// This could be one of: a tuple-like enum variant, a
// struct-like enum variant, or a struct.
match ccx.tcx.def_map.find(&cur.id) {
Some(&ast::def_fn(*)) |
Some(&ast::def_variant(*)) => {
add_to_set(ccx.tcx, &mut found,
variant_opt(bcx, cur.id));
Expand Down Expand Up @@ -1011,6 +1013,7 @@ pub fn any_tuple_struct_pat(bcx: block, m: &[@Match], col: uint) -> bool {
match pat.node {
ast::pat_enum(_, Some(_)) => {
match bcx.tcx().def_map.find(&pat.id) {
Some(&ast::def_fn(*)) |
Some(&ast::def_struct(*)) => true,
_ => false
}
Expand Down Expand Up @@ -1780,6 +1783,7 @@ pub fn bind_irrefutable_pat(bcx: block,
}
}
}
Some(&ast::def_fn(*)) |
Some(&ast::def_struct(*)) => {
match *sub_pats {
None => {
Expand Down

0 comments on commit b50aa82

Please sign in to comment.