Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cleanup error messages for anonymous impl for types not declared in t…
- Loading branch information
Showing
6 changed files
with
163 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// ignore-tidy-linelength | ||
|
||
pub struct Foo; | ||
|
||
mod bar { | ||
use Foo; | ||
|
||
impl Foo { //~ERROR inherent implementations are only allowed on types defined in the current module | ||
fn baz(&self) {} | ||
} | ||
} | ||
fn main() {} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// ignore-tidy-linelength | ||
|
||
struct Foo { | ||
x: int | ||
} | ||
|
||
impl Fo { //~ERROR inherent implementations are not allowed for types not defined in the current module. | ||
fn foo() {} | ||
} | ||
|
||
fn main() {} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// ignore-tidy-linelength | ||
|
||
pub mod a { | ||
pub struct Foo { a: uint } | ||
} | ||
|
||
pub mod b { | ||
use a::Foo; | ||
impl Foo { //~ERROR inherent implementations are only allowed on types defined in the current module | ||
fn bar(&self) { } | ||
} | ||
} | ||
|
||
pub fn main() { } | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// ignore-tidy-linelength | ||
|
||
impl B { //~ERROR inherent implementations are not allowed for types not defined in the current module. | ||
} | ||
|
||
fn main() { | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb58079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at apoelstra@bb58079
bb58079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging apoelstra/rust/error-on-unknown-impl = bb58079 into auto
bb58079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apoelstra/rust/error-on-unknown-impl = bb58079 merged ok, testing candidate = b9478ee
bb58079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1577
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1574
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1568
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1574
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1571
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1570
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1570
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1574
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1568
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1567
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1570
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1225
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1223
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1226
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/59
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/57
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/58
bb58079
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = b9478ee