Skip to content

Commit

Permalink
Consider target_family as pal
Browse files Browse the repository at this point in the history
Currently tidy does not consider code in target_family as
platform-specific. I think this is erroneous and should be fixed.

Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
  • Loading branch information
Ayush1325 committed Mar 8, 2023
1 parent 7c306f6 commit d75dae2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/tools/tidy/src/pal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ const EXCEPTION_PATHS: &[&str] = &[
"library/std/src/panic.rs", // fuchsia-specific panic backtrace handling
"library/std/src/personality.rs",
"library/std/src/personality/",
"library/std/src/thread/mod.rs",
"library/std/src/thread/local.rs",
];

pub fn check(path: &Path, bad: &mut bool) {
Expand Down Expand Up @@ -128,6 +130,7 @@ fn check_cfgs(
|| cfg.contains("target_env")
|| cfg.contains("target_abi")
|| cfg.contains("target_vendor")
|| cfg.contains("target_family")
|| cfg.contains("unix")
|| cfg.contains("windows");

Expand Down

0 comments on commit d75dae2

Please sign in to comment.