-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
std: remove the
equals
method from TotalEq
.
`TotalEq` is now just an assertion about the `Eq` impl of a type (i.e. `==` is a total equality if a type implements `TotalEq`) so the extra method is just confusing. Also, a new method magically appeared as a hack to allow deriving to assert that the contents of a struct/enum are also TotalEq, because the deriving infrastructure makes it very hard to do anything but create a trait method. (You didn't hear about this horrible work-around from me :(.)
- Loading branch information
Showing
23 changed files
with
74 additions
and
208 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
f6db0ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from thestinger
at huonw@f6db0ef
f6db0ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging huonw/rust/totaleq-deriving = f6db0ef into auto
f6db0ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huonw/rust/totaleq-deriving = f6db0ef merged ok, testing candidate = 903e838
f6db0ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4844
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4840
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3937
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3945
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4943
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4031
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4038
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4945
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4031
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4036
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4104
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1835
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4942
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4042
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4050
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4704
f6db0ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 903e838