Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::hashmap::{each_key, each_value} with iterators #11216

Closed
Dretch opened this issue Dec 30, 2013 · 1 comment
Closed

Replace std::hashmap::{each_key, each_value} with iterators #11216

Dretch opened this issue Dec 30, 2013 · 1 comment

Comments

@Dretch
Copy link
Contributor

Dretch commented Dec 30, 2013

It feels surprising to me that each_key and each_value still use the old closure-based iteration protocol.

I think it would be better if they were replaced with keys and values methods that return new-style iterators.

I can send a pull request, unless there are objections.
Dretch added a commit to Dretch/rust that referenced this issue Dec 31, 2013
@Dretch
Fix issue rust-lang#11216 - Replace std::hashmap::{each_key, each_val…
d435f4f 
…ue} with iterators.
@gereeter
Copy link
Contributor

This is fixed with the merging of #11242 and should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dretch @thestinger @gereeter