internal compiler error: cannot get field types from the enum type Foo without a node ID #11577

pzol · 2014-01-15T19:17:04Z

#[feature(struct_variant)];

enum Foo {
  Bar { num: int}
}

fn test_foo() {
  let bar = Bar { num: 1 };
  let Bar { num } = bar;
}

task 'rustc' failed at 'explicit failure', /Users/pzol/rust/rust/src/libsyntax/diagnostic.rs:75
task '

' failed at 'explicit failure', /Users/pzol/rust/rust/src/librustc/lib.rs:453

rustc -v
rustc 0.10-pre (29070c3 2014-01-14 23:01:51 -0800)
host: x86_64-apple-darwin

The text was updated successfully, but these errors were encountered:

We weren't passing the node id for the enum and hence it couldn't retrieve the field types for the struct variant we were trying to destructure. Fixes #11577.

new lint: `unnecessary_fallible_conversions` Closes rust-lang#11577 A new lint that looks for calls such as `i64::try_from(1i32)` and suggests `i64::from(1i32)`. See lint description (and linked issue) for more details for why. There's a tiny bit of overlap with the `useless_conversion` lint, in that the other one warns `T::try_from(T)` (i.e., fallibly converting to the same type), so this lint ignores cases like `i32::try_from(1i32)` to avoid emitting two warnings for the same expression. Also, funnily enough, with this one exception, this lint would warn on exactly every case in the `useless_conversion_try` ui test that `useless_conversion` didn't cover (but never two warnings at the same time), which is neat. I did add an `#![allow]` though since we don't want interleaved warnings from multiple lints in the same uitest. changelog: new lint: `unnecessary_fallible_conversions`

luqmana mentioned this issue Mar 1, 2014

librustc: Pass the node id so we don't fail on destructing struct variants #12639

Merged

bors added a commit that referenced this issue Mar 1, 2014

auto merge of #12639 : luqmana/rust/struct-variant-pat, r=pcwalton

3d117cf

We weren't passing the node id for the enum and hence it couldn't retrieve the field types for the struct variant we were trying to destructure. Fixes #11577.

luqmana closed this as completed in 715e618 Mar 1, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal compiler error: cannot get field types from the enum type Foo without a node ID #11577

internal compiler error: cannot get field types from the enum type Foo without a node ID #11577

pzol commented Jan 15, 2014

internal compiler error: cannot get field types from the enum type Foo without a node ID #11577

internal compiler error: cannot get field types from the enum type Foo without a node ID #11577

Comments

pzol commented Jan 15, 2014