Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: cargo output is missing #117315

Closed
matthiaskrgr opened this issue Oct 28, 2023 · 0 comments · Fixed by #117322
Closed

bootstrap: cargo output is missing #117315

matthiaskrgr opened this issue Oct 28, 2023 · 0 comments · Fixed by #117322
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

x.py install

Documenting error index (x86_64-unknown-linux-gnu)
Building tool error_index_generator (stage1 -> stage2, x86_64-unknown-linux-gnu)
Rustbook (x86_64-unknown-linux-gnu) - nomicon
Rustbook (x86_64-unknown-linux-gnu) - reference
Rustbook (x86_64-unknown-linux-gnu) - rust-by-example
Generating lint docs (x86_64-unknown-linux-gnu)
Uplifting library (stage1 -> stage2)
Building stage0 tool lint-docs (x86_64-unknown-linux-gnu)
Running stage2 lint-docs (x86_64-unknown-linux-gnu)
Rustbook (x86_64-unknown-linux-gnu) - embedded-book
Building stage0 tool rust-installer (x86_64-unknown-linux-gnu)
Dist rust-docs-1.75.0-dev-x86_64-unknown-linux-gnu
	finished in 8.794 seconds
Installing stage2 docs (x86_64-unknown-linux-gnu)
install: uninstalling component 'rust-docs'
install: creating uninstall script at /home/matthias/.rustup/toolchains/local-debug-assertions/lib/rustlib/uninstall.sh
install: installing component 'rust-docs'

    rust docs installed.

Dist rust-std-1.75.0-dev-x86_64-unknown-linux-gnu
	finished in 2.423 seconds
Installing stage2 std (x86_64-unknown-linux-gnu)
install: uninstalling component 'rust-std-x86_64-unknown-linux-gnu'
install: creating uninstall script at /home/matthias/.rustup/toolchains/local-debug-assertions/lib/rustlib/uninstall.sh
install: installing component 'rust-std-x86_64-unknown-linux-gnu'

    rust std installed.

Uplifting rustc (stage1 -> stage3)
Building tool cargo (stage2 -> stage3, x86_64-unknown-linux-gnu)

There is no Compiling $dep output for cargo for example
@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Oct 28, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 28, 2023
@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 28, 2023
@onur-ozkan onur-ozkan self-assigned this Oct 28, 2023
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 28, 2023
@onur-ozkan onur-ozkan mentioned this issue Oct 28, 2023
Merged
@bors bors closed this as completed in 771b255 Oct 29, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 29, 2023
@rust-timer
Unrolled build for rust-lang#117322
0d52265 
Rollup merge of rust-lang#117322 - onur-ozkan:fix-suppressed-outputs, r=Kobzol

change default output mode of `BootstrapCommand`

`SuppressOnSuccess` on `BootstrapCommand` is a problematic default mode as it affects the logs during the bootstrapping (as shown in the screenshot below). The default behavior should be to print everything unless we explicitly modify the behavior within build steps.

![image](https://github.com/rust-lang/rust/assets/39852038/8dbaaeb2-0656-4ff9-8e48-1ac0734a913f)

Fixes rust-lang#117315

cc `@Kobzol`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change default output mode of BootstrapCommand onur-ozkan/rust
3 participants
@matthiaskrgr @onur-ozkan @rustbot