using RUST_BOOSTRAP_CONFIG to configure x.py can break boostrap tests
#120202
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
rustbot
added
needs-triage
|
if rust-lang/rustc-dev-guide#1858 is accepted, this would be somewhat lower priority (though not fixed) |
onur-ozkan
removed
the
needs-triage
No, it's not. It's just a logical bug in the test that I will fix quickly. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jan 30, 2024
check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 30, 2024
check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this issue
Jan 31, 2024
check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this issue
Jan 31, 2024
check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this issue
Jan 31, 2024
check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 31, 2024
Rollup merge of rust-lang#120207 - onur-ozkan:120202-fix, r=clubby789 check `RUST_BOOTSTRAP_CONFIG` in `profile_user_dist` test Fixes a logical bug in `profile_user_dist` test (explained in rust-lang#120202).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When setting
RUST_BOOTSTRAP_CONFIG(for x.py) to a path that doesn't end in a file namedconfig.toml(orconfig.dist.toml) thebootstraptestprofile_user_distfails, due to explicitly asserting that the config file has one of these names(test is
src/bootstrap/src/tests/config.rs:175)This could be indicitive of a larger issue, as Config::parse_inner which is used in many bootstrap tests seems to rely on a concerning amount of external state (this could cause more issues in the future if not resolved, and/or make bootstrap's tests fail when a users config is invalid)
If this behavior is intentional, there is a bug in
rustc_dev_guide, because the recommended shell.nix setsRUST_BOOTSTRAP_CONFIG=/nix/store/some/path/rustc-configwhich triggers this bugAlternately, ./x.py could emit an error if RUST_BOOTSTRAP_CONFIG is set to an invalid path, with a suggestion on how to fix it (though this seems like a questionable fix)
@rustbot label +C-bug +T-bootstrap
The text was updated successfully, but these errors were encountered: