Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for derive_skip #121050

Open
1 of 4 tasks
clubby789 opened this issue Feb 13, 2024 · 2 comments
Open
1 of 4 tasks

Tracking Issue for derive_skip #121050

clubby789 opened this issue Feb 13, 2024 · 2 comments
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@clubby789
Copy link
Contributor

clubby789 commented Feb 13, 2024

This is a tracking issue for rust-lang/libs-team#334.
The feature gate for the issue is #![feature(derive_skip)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • How to deal with unhandled/typo arguments (e.g. #[skip(Degub)]
  • Support for 3rd party derives, or just builtins
  • Should #[skip = "Debug"] work?
  • Handling #[skip] when not all derives support it
  • Interaction with StructuralPartialEq

Implementation history

@clubby789 clubby789 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Feb 13, 2024
@jplatte
Copy link
Contributor

jplatte commented Feb 14, 2024

I wonder, if any fields are skipped in Debug, should finish_non_exhaustive be used automatically instead of plain finish?

bors added a commit to rust-lang-ci/rust that referenced this issue Feb 16, 2024
Implement `#[skip]` for builtin derives

Implement rust-lang#121050

Still needs some work but here's an initial working implementation to get feedback on the strategy.
@dead-claudia
Copy link

Related ACP: rust-lang/libs-team#334

bors added a commit to rust-lang-ci/rust that referenced this issue Apr 24, 2024
Implement `#[skip]` for builtin derives

Implement rust-lang#121050

Still needs some work but here's an initial working implementation to get feedback on the strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants