Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text color dark gray but background color default leads to unreadable text with dark theme #121954

Closed
FalcoGer opened this issue Mar 3, 2024 · 2 comments · Fixed by #122087
Closed

Text color dark gray but background color default leads to unreadable text with dark theme #121954

FalcoGer opened this issue Mar 3, 2024 · 2 comments · Fixed by #122087
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug.

Comments

@FalcoGer
Copy link

FalcoGer commented Mar 3, 2024 •
edited
Loading

When running rustup doc, this file is opened for me ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html. I thought I'd use that file in my note taking application, which I have set to a dark theme. However the css for body in that documentation is set to have the color = #333; and the background uses the default color.

This leads to the text becoming hard to read.

image

I would prefer the text color not to be explicitly set, or if you insist on the dark gray text, making sure that the background color is also set to something light.
@ehuss ehuss transferred this issue from rust-lang/reference Mar 3, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 3, 2024
@ehuss
Copy link
Contributor

ehuss commented Mar 3, 2024

Transferred to rust-lang/rust. The CSS for this lives at https://github.com/rust-lang/rust/blob/HEAD/src/doc/rust.css.

@jieyouxu jieyouxu added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 4, 2024
@GuillaumeGomez GuillaumeGomez added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 6, 2024
@GuillaumeGomez
Copy link
Member

It's not rustdoc so to speak. I'll fix the issue.

@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 6, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Mar 7, 2024
@workingjubilee
Rollup merge of rust-lang#122087 - GuillaumeGomez:fix-rust-index-page…
3e865a9 
…, r=notriddle

Add missing background color for top-level rust documentation page and increase contrast by setting text color to black

Fixes rust-lang#121954.

r? `@notriddle`
@bors bors closed this as completed in 3257e86 Mar 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 8, 2024
@rust-timer
Unrolled build for rust-lang#122087
395ac03 
Rollup merge of rust-lang#122087 - GuillaumeGomez:fix-rust-index-page, r=notriddle

Add missing background color for top-level rust documentation page and increase contrast by setting text color to black

Fixes rust-lang#121954.

r? ``@notriddle``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
5 participants
@ehuss @GuillaumeGomez @FalcoGer @jieyouxu @rustbot