-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MC/DC LLVM 19 intrinsics changes #126672
Comments
As far as I know, works on mcdc need to be done for adapting to llvm 19 are:
These changes are definite since they have been merged into llvm now, while still there are other changes may be introduced. Given that Edit. Other works have been done, but |
In the short-term, we can just adjust the tests to not run on LLVM 19. After the in-tree LLVM has been updated to LLVM 19, then we can remove support for MC/DC under LLVM 18, and add support for MC/DC under LLVM 19. (Unless someone wants to do the extra work of supporting MC/DC with LLVM 19 before the official upgrade.) |
@rustbot label -needs-triage +A-LLVM +T-compiler +C-enhancement |
This sounds acceptable if we defer stabilizing MC/DC until our minimum LLVM is 19+ |
Filed #126733 to fix it and prepare for llvm 19. |
If all goes well, I expect we'll try to land the LLVM 19 update next week, with broken MC/DC support if it's not ready in time. |
In LLVM 19 some details about MC/DC changed, removing and updating some intrinsics:
In instrprof_mcdc_condbitmap_update intrinsic was dropped recently:
I tried naively to remove the reference to the removed intrinsic #126582, but that's incomplete. Will need more work to adapt to this it seems:
The text was updated successfully, but these errors were encountered: