Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't compile .rs files with utf-8 BOM #12974

Closed
liigo opened this issue Mar 17, 2014 · 0 comments
Closed

Can't compile .rs files with utf-8 BOM #12974

liigo opened this issue Mar 17, 2014 · 0 comments

Comments

@liigo
Copy link
Contributor

liigo commented Mar 17, 2014

Files with utf-8 BOM are valid UTF-8 encoded files. Most text-editors support creating and editing them. BOM should not prevent .rs files from compiling. We could just ignore the BOM bytes silently.
@liigo liigo mentioned this issue Mar 17, 2014
Closed
liigo added a commit to liigo/rust that referenced this issue Mar 18, 2014
@liigo
libsyntax: librustdoc: ignore utf-8 BOM in .rs files
4983718 
Closes rust-lang#12974
@andersforsgren andersforsgren mentioned this issue Oct 7, 2015
Closed
lnicola pushed a commit to lnicola/rust that referenced this issue Aug 16, 2022
@bors
Auto merge of rust-lang#12974 - fprasx:master, r=lnicola
554f7f8 
Corrected order of printing op and `=`

Fixes rust-lang/rust-analyzer#12971 where `Display` impl for assignment operators does `=+` instead of `+=`
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 11, 2024
@bors
Auto merge of rust-lang#12974 - alex-semenyuk:rename_thread_local_ini…
3ed690f 
…tializer_can_be_made_const, r=Alexendoo

Rename thread_local_initializer_can_be_made_const to missing_const_for_thread_local

Close rust-lang#12934
As discussed at rust-lang#12934 name `thread_local_initializer_can_be_made_const` sounds against convention for other lints which describe the issue/wrong code but not suggestion and it is quite long. The new name take example from existing lint `missing_const_for_fn`

changelog: `thread_local_initializer_can_be_made_const` : Rename to [`missing_const_for_thread_local`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libsyntax: librustdoc: ignore utf-8 BOM in .rs files liigo/rust
1 participant
@liigo