Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a control flow graph to the compiler #13767

Closed
brson opened this issue Apr 25, 2014 · 2 comments · Fixed by #14873
Closed

Introduce a control flow graph to the compiler #13767

brson opened this issue Apr 25, 2014 · 2 comments · Fixed by #14873
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Apr 25, 2014

Several pending features depend on a control flow graph, including #5016. Nominating.
@pnkfelix pnkfelix added this to the 1.0 milestone May 1, 2014
@pnkfelix
Copy link
Member

pnkfelix commented May 1, 2014

Assign P-backcompat-lang, 1.0 milestone.

@pcwalton pcwalton mentioned this issue Jun 13, 2014
Merged
bors added a commit that referenced this issue Jun 18, 2014
@bors
auto merge of #14873 : pnkfelix/rust/fsk-dataflow-revisions, r=nikoma…
4416b32 
…tsakis

Fix #6298.  Fix  #13767.

This also includes some drive by fixes for some other issues, noted in the commits.

I still need to integrate regression tests for some cases that I noticed were missing from our unit test suite (i.e. things that compiling rustc exposes that should have been exposed when doing `make check-stage1`).  So do not land this yet, until I get the chance to add those tests.

I just wanted to get the review process started soon, since this has been long in the coming.
@brson
Copy link
Contributor Author

brson commented Jun 18, 2014

Woohoo! Awesome work, @pnkfelix

arcnmx pushed a commit to arcnmx/rust that referenced this issue Jan 9, 2023
@ntBre
return immediately from render_tuple_lit if snippet_cap is None
1116cc9 
partially addresses rust-lang#13767
arcnmx pushed a commit to arcnmx/rust that referenced this issue Jan 9, 2023
@bors
Auto merge of rust-lang#13805 - ntBre:master, r=jonas-schievink
5c8f00f 
Complete enum variants without parens when snippets are disabled

This handles the portion of rust-lang#13767 that bothered me, but I can try to work on the other parts we discussed if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Revise dataflow to use middle::cfg flowgraph to drive analysis. pnkfelix/rust
2 participants
@brson @pnkfelix