Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAudit reference manual before 1.0 #16676
Comments
brson
added
A-docs
labels
Aug 22, 2014
This comment has been minimized.
This comment has been minimized.
|
Very yes. |
brson
added this to the 1.0 milestone
Sep 4, 2014
brson
added
the
P-high
label
Sep 4, 2014
aturon
self-assigned this
Sep 4, 2014
This comment has been minimized.
This comment has been minimized.
|
I'm going to assign this to myself, as we decided at the work week, but I will be working with/delegating to others on actually carrying this out. |
alexcrichton
removed
the
I-nominated
label
Sep 4, 2014
This comment has been minimized.
This comment has been minimized.
|
Re-nominating. Should this be on the beta milestone? |
aturon
added
the
I-nominated
label
Jan 8, 2015
This comment has been minimized.
This comment has been minimized.
|
leaving on the 1.0 milestone; this is considered polish, after we've finished all the backwards incompat stuff. |
pnkfelix
removed
the
I-nominated
label
Jan 8, 2015
This was referenced Feb 16, 2015
This comment has been minimized.
This comment has been minimized.
mdinger
referenced this issue
Apr 23, 2015
Closed
reference grammar: no_struct_literal_expr undefined #24723
This comment has been minimized.
This comment has been minimized.
|
Audited section 5, Crates and source files. Filed PR #24727 to fix it. |
joliv
added a commit
to joliv/rust
that referenced
this issue
Apr 23, 2015
joliv
referenced this issue
Apr 23, 2015
Merged
Clarify unit expressions section of reference #24738
This comment has been minimized.
This comment has been minimized.
|
I'm reading 8.1, the types chapter. PR #24744 I didn't really cover 8.1.13 Self types, someone should look at that again. |
This comment has been minimized.
This comment has been minimized.
|
EDIT: Let me rescind that—I'm told that, as the unit type is no longer viewed as being separate from the tuple, the reference is going to need a bit more of an overhaul than what I've done in the PR, including possibly taking out the section I've edited. |
This comment has been minimized.
This comment has been minimized.
|
Audited 3.3 (Comments). Filed #24740 for a small clarification. Aside from that it looks good, although I think the EBNF is a little sketchy. ( |
This comment has been minimized.
This comment has been minimized.
|
Audited 3.5.1 (Keywords). Filed #24742 to add two missing keywords. |
This comment has been minimized.
This comment has been minimized.
|
6.1.4 (Type Aliases) looks good to me. |
This comment has been minimized.
This comment has been minimized.
|
#24753 - describe Range expressions |
This comment has been minimized.
This comment has been minimized.
jackm321
commented
Apr 24, 2015
|
If the unit type is no longer present, will unit-like structs be renamed to something else? |
nwin
added a commit
to nwin/rust
that referenced
this issue
Apr 24, 2015
This comment has been minimized.
This comment has been minimized.
|
Thanks @badboy ! I believe you are right, would you mind sending a PR? |
This comment has been minimized.
This comment has been minimized.
|
Will do |
This comment has been minimized.
This comment has been minimized.
|
@steveklabnik read through some of chapter 7, wouldn't want to greenlight it yet but found what I think is a small issue and made a pr: #25286 |
This comment has been minimized.
This comment has been minimized.
|
Audited as ok:
Pending PR #25290 to fix:
|
This comment has been minimized.
This comment has been minimized.
|
Since #24863 was merged, all of 3.5.2 can be marked as done (sorry bluss for letting you repeat work) |
This comment has been minimized.
This comment has been minimized.
|
Well since I read the fixed version it was easy :) |
nham
referenced this issue
May 11, 2015
Closed
Audit traits and (partially) trait objects sections of Reference #25308
This comment has been minimized.
This comment has been minimized.
|
I read 6.1.9 (and part of 8.1.11) and submitted a PR: #25308 |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
May 11, 2015
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
May 12, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
May 13, 2015
bors
added a commit
that referenced
this issue
May 13, 2015
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
May 13, 2015
steveklabnik
removed this from the 1.0 milestone
May 21, 2015
This comment has been minimized.
This comment has been minimized.
|
I'm considering this closed, as both @nikomatsakis and I did a full read-over, and the community chipped in a ton as well. Future improvements to the reference are always welcome, of course. |
brson commentedAug 22, 2014
Shortly before 1.0 we should give some attention to the manual and make sure it's not too inaccurate nor incomplete.
Let's crowdsource this edit! Please check one of these sections, and leave a comment below if you've verified that it's accurate or have sent a PR fixing part: