Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make check_match not copy the AST #17253

Closed
ghost opened this issue Sep 14, 2014 · 3 comments
Closed

Make check_match not copy the AST #17253

ghost opened this issue Sep 14, 2014 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@ghost
Copy link

ghost commented Sep 14, 2014

After #13316 check_match is a major bottleneck in the cycle time of rustc taking 4 times more time than it did before (18-19 s vs 4.5 s).

The main problem is the static inliner which creates new AST nodes. It should be possible to make it not do that.
@eddyb
Copy link
Member

eddyb commented Sep 14, 2014

Have you checked after I removed the clone call which resulted in short-lived copies amounting to 2-3 times the crate size?

@ghost
Copy link
Author

ghost commented Sep 18, 2014

I hear it's miraculously back to 4s. The bug is still valid, though.

@steveklabnik steveklabnik added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jan 27, 2015
@steveklabnik
Copy link
Member

This is an old bug, and the original reporter is gone, and the compiler has gone through a ton of stuff, so just closing.

lnicola pushed a commit to lnicola/rust that referenced this issue Jun 2, 2024
@bors
Auto merge of rust-lang#17253 - ThouCheese:master, r=Veykril
cbd40a2 
Implement assist to switch between doc and normal comments

Hey first PR to rust-analyzer to get my feet wet with the code base. It's an assist to switch a normal comment to a doc comment and back, something I've found myself doing by hand a couple of times.

I shamelessly stole `relevant_line_comments` from `convert_comment_block`, because I didn't see any inter-assist imports happening in the files I peeked at so I thought this would be preferable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @eddyb