Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve chunk allocation scheme used by Arena / TypedArena #17931

Closed
thestinger opened this issue Oct 10, 2014 · 0 comments
Closed

improve chunk allocation scheme used by Arena / TypedArena #17931

thestinger opened this issue Oct 10, 2014 · 0 comments
Labels
A-allocators Area: Custom and system allocators I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

It should attempt in-place growth before falling back to allocating a new chunk. The initial size and growth should be chosen to map well onto jemalloc. Rather than an intrusive linked list of chunks, it should probably just keep the metadata out of band for simplicity and to avoid bumping the allocations into a higher size class.
@thestinger thestinger added I-slow Issue: Problems and improvements with respect to performance of generated code. A-allocators Area: Custom and system allocators labels Oct 10, 2014
@thestinger thestinger self-assigned this Oct 10, 2014
@thestinger thestinger removed their assignment Jan 28, 2015
@emberian emberian self-assigned this Mar 25, 2015
@pczarn pczarn mentioned this issue Aug 13, 2015
Merged
@emberian emberian removed their assignment Jan 5, 2016
pczarn added a commit to pczarn/rust that referenced this issue Jan 5, 2016
@pczarn
Improve TypedArena's chunk allocation scheme
803e9ae 
Closes rust-lang#17931
Fixes rust-lang#18037
bors added a commit that referenced this issue Jan 11, 2016
@bors
Auto merge of #27807 - pczarn:arena-internals, r=bluss
dfaddb7 
Fixes #18037 "TypedArena cannot handle zero-sized types".
Closes #17931 "improve chunk allocation scheme used by Arena / TypedArena".
Closes #22847 "TypedArena should implement Send". - N.B. Arena cannot implement Send, since it may contain non-Send values.
Closes #18471 "`Arena::alloc_copy_inner` (at least) should be renamed and made public." - Added `Arena::alloc_bytes`.
Closes #18261 "support clearing TypedArena with the chunks preserved". - Only the largest chunk is preserved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-allocators Area: Custom and system allocators I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emberian @thestinger