Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for all variants of ast::WherePredicate in clean/mod.rs #20048

Closed
jroesch opened this issue Dec 19, 2014 · 2 comments · Fixed by #20180
Closed

Add support for all variants of ast::WherePredicate in clean/mod.rs #20048

jroesch opened this issue Dec 19, 2014 · 2 comments · Fixed by #20180
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jroesch
Copy link
Member

jroesch commented Dec 19, 2014

This is related to #20041 and #20002. We currently only support the cleaning of the BoundPredicate variant, we should support RegionPredicate, and once implemented EqualityPredicate as well.
@jroesch jroesch changed the title Add support for the different variants of ast::WherePredicate in clean/mod.rs Add support for all variants of ast::WherePredicate in clean/mod.rs Dec 19, 2014
@jroesch jroesch mentioned this issue Dec 19, 2014
Merged
@tomjakubowski
Copy link
Contributor

I'll get on this once #20002 lands, or if you prefer and think the types are relatively stable I can send you a patch to add to #20002 (it should be relatively small).

@bstrie bstrie added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 20, 2014
@jroesch
Copy link
Member Author

jroesch commented Dec 20, 2014

I made some progress on #20049 earlier today, might want to wait until that lands since it changes the types slightly. I think #20002 should be good to go as soon as Niko gives the final okay.

@jroesch jroesch mentioned this issue Dec 20, 2014
Closed
@jroesch jroesch mentioned this issue Dec 23, 2014
Merged
jroesch added a commit to jroesch/rust that referenced this issue Dec 23, 2014
@jroesch
Support all variants of WherePredicate
6948a2d 
Adds support for all variants of ast::WherePredicate in clean/mod.rs. Fixes rust-lang#20048, but will need modification when EqualityPredicates are fully implemented in rust-lang#20041.
bors added a commit that referenced this issue Dec 25, 2014
@bors
auto merge of #20180 : jroesch/rust/clean-where-predicate, r=alexcric…
5ba6102 
…hton

Add support for all variants of ast::WherePredicate in clean/mod.rs. Fixes #20048, but will need modification when EqualityPredicates are fully implemented in #20041.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support all variants of WherePredicate in clean/mod.rs jroesch/rust
3 participants
@tomjakubowski @jroesch @bstrie