-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dist automation security #20629
Comments
CC @bheesham |
Nominating because this could cause very bad problems if a stable release gets overwritten. |
It looks like creating a |
I believe this has been fixed, but feel free to correct me @brson |
I don't consider this fixed yet because buildbot is still not behind HTTPS. |
Proxying requests to Buildbot through a server that supports TLS is the only way to get HTTPS working with Buildbot. The buildbot web interface is already being proxied through nginx, so the configuration just needs to be tweaked to get it to be served over HTTPS. |
Shouldn't this be P-High? It is a security vulnerability. |
@DemiMarie thanks for the ping here. I believe that at one point, we re-named |
I've now configured letsencrypt and buildbot is behind HTTPS now, so I'm gonna close this. @brson though if I'm forgetting something feel free to reopen! |
@alexcrichton Not @brson, just thinking in general about security, but just wondering if the buildbot credentials should be changed, since the current ones might have been leaked (and possibly changed to use TLS client certificates). HPKP might also be useful (the buildbot certificate should never change without everyone knowing). |
@DemiMarie yes that's a good idea to change the passwords. |
Our buildbot instance is set up so that anybody with the not-so-secret credentials can trigger a build. At present this means that anybody can publish any commit in the repo to a release channel at will.
The text was updated successfully, but these errors were encountered: