Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--attr flag #2219

Closed
brson opened this issue Apr 16, 2012 · 7 comments
Closed

--attr flag #2219

brson opened this issue Apr 16, 2012 · 7 comments
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@brson
Copy link
Contributor

brson commented Apr 16, 2012

Works in conjunction with #612. Like a configuration file that merges crate attributes, the --attr flag allows arbitrary attributes to be merged into the crate.
@brson
Copy link
Contributor Author

brson commented Apr 16, 2012

A lot of existing flags could be folded into this one. For example --cfg debug would become --attr with_cfg(debug) (assuming with_cfg becomes a real attribute.

@bstrie
Copy link
Contributor

bstrie commented Apr 26, 2013

Does rustpkg make this obsolete?

@emberian
Copy link
Member

emberian commented Jul 5, 2013

@catamorphism ?

@ghost ghost assigned catamorphism Aug 20, 2013
@catamorphism
Copy link
Contributor

rustpkg has partial support for this. Added pkg label to remind us to get to it.

@pnkfelix
Copy link
Member

wait, I interpret this bug as asking for a rustc option. If someone chooses to use rustc and not use rustpkg, they might well want this, no?

@huonw
Copy link
Member

huonw commented Feb 8, 2014

Triage, no change.

@steveklabnik
Copy link
Member

In the days of Cargo, I don't think that this is particularly relevant to rustc. @brson feel free to re-open if you disagree.

bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2219 - saethlin:more-benchmarks, r=RalfJung
32a7580 
Add more bench-cargo-miri programs

These example programs are derived from long-running (>15 minutes) tests in the test suites of highly-downloaded crates (if I have my way, that runtime will not be correct for long). They should serve as realistic but also somewhat pathological workloads for the interpreter.

The unicode program stresses the code which looks for adjacent and equal stacks to merge them.
The backtraces program has an uncommonly large working set of borrow tags per borrow stack.

This also updates the .gitignore to ignore files commonly emitted in the course of using these benchmark programs.

---

The benchmark programs are so-named to avoid confusingly duplicating the names of the crates they are benchmarking. Is that a good idea? I started doing this so that I could use `cargo add` but now I'm not entirely sold on the names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@steveklabnik @brson @pnkfelix @catamorphism @emberian @bstrie @huonw